Re: GtkClist 1.2.8 bug and patch

[Dave Lambert <dlambert acm org>]

>>>>> "Dave" == Dave Lambert <dlambert acm org> writes:

Dave> +  g_return_val_if_fail (column < 0 || column >= clist->columns, 0);

Oops.  That should read:

g_return_val_if_fail (column >= 0 && column < clist->columns, 0);

Right, third time lucky?  


--- gtkclist.c.orig	Thu Dec 14 09:54:50 2000
+++ gtkclist.c	Thu Dec 14 10:54:20 2000
@@ -1699,9 +1699,7 @@
 
   g_return_val_if_fail (clist != NULL, 0);
   g_return_val_if_fail (GTK_CLIST (clist), 0);
-
-  if (column < 0 || column > clist->columns)
-    return 0;
+  g_return_val_if_fail (column >= 0 && column < clist->columns, 0);
 
   if (GTK_CLIST_SHOW_TITLES(clist) && clist->column[column].button)
     width = (clist->column[column].button->requisition.width)


Dave

-- 
Dave Lambert		mailto://dlambert acm org
Portsmouth, England	phone-home://+44 23 9236 5439
[This space for sale]	phone-work://+44 23 9233 6272
--
`We've come to fish for the herring fish,
With nets of silver and gold,'
Said Winkle, Twinkle, and Nod.