Re: GDK_NOR

[David Odin <David Odin bigfoot com>]

OK, as nobody respond to this,

On Sun, Aug 01, 1999 at 07:55:34PM +0200, David Odin wrote:
> 
>   Hi,
> 
> I'm looking into the GC logical function. Is there any reasons the GDK_NOR
> function isn't implemented? I mean I know it isn't very useful, but I'm
> wondering why all the other GC-logical-function are implemented and not that
> one... It could be added at a very low price (two lines in gdkgc.h plus one
> in gdktypes.h)
> 
>     Regards
> 
>                  DindinX
> 
  let me reformulate this. I think I have found a bug in GDK. The GDK_NOR
function isn't implemented for no good reason. So here is a patch to add
it to the list of supported GC logical functions :


--- gdktypes.h.orig	Wed Feb 24 11:14:56 1999
+++ gdktypes.h	Mon Aug  2 17:45:50 1999
@@ -255,6 +255,7 @@
   GDK_AND_INVERT,
   GDK_NOOP,
   GDK_OR,
+  GDK_NOR,
   GDK_EQUIV,
   GDK_OR_REVERSE,
   GDK_COPY_INVERT,
--- gdkgc.c.orig	Mon Aug  2 17:48:14 1999
+++ gdkgc.c	Mon Aug  2 17:46:49 1999
@@ -114,6 +114,9 @@
 	case GDK_OR:
 	  xvalues.function = GXor;
 	  break;
+	case GDK_NOR:
+	  xvalues.function = GXnor;
+	  break;
 	case GDK_EQUIV:
 	  xvalues.function = GXequiv;
 	  break;

This very little patch doesn't break anything and make the GDK more accurate
in respect to the wrapping of the Xlib's XSetFunction().
 
         Regards,
          
                     DindinX

-- 
David.Odin@bigfoot.com

"Today's robots are very primitive, capable of understanding only a few
 simple instructions such as 'go left', 'go right', and 'build car'."
 --John Sladek