Re: const fixes seek commit approval

[Owen Taylor <otaylor redhat com>]

Havoc Pennington <rhpennin@midway.uchicago.edu> writes:

> Can I commit this patch?

[...] 

> +	(gtk_clist_get_text): returned strings are const
> +	(gtk_clist_get_pixtext): returned strings are const

[ much more of same ]

Please don't. const returns are infectious - they force people who
don't care about 'const' to either add lots of explicit casts
or to make their entire program "const correct" simply to
avoid warnings.

const parameters are much more appropriate - they allow people
who want 'const' to avoid casts, and don't force anything
on people who don't want to deal with 'const' - so if you
can make up a version of your patch which avoids const'ifying
return values, that would be much nicer.

Regards,
                                        Owen