Re: GNOME CVS: glib yosh

[Raja R Harinath <harinath cs umn edu>]

Gnome CVS User <gnomecvs@cvs.labs.redhat.com> writes:
> CVSROOT:	/cvs/gnome
> Module name:	glib
> Changes by:	yosh	98/11/04 23:07:25
> 
> Modified files:
> 	.              : ChangeLog glib.def glibconfig.h.win32 
> 	                 makefile.msc 
> Added files:
> 	.              : config.h.win32 
> 
> Log message:
> * config.h.win32 (new file)
> * glibconfig.h.win32
> * glib.def
> * makefile.msc: applied glib-tml-981104, win32 sync

Now that there's a handcrafted `glibconfig.h.win32', does is make sense
to push all those

	#pragma warning

in there, so that `glib.h' is less cluttered?  

Another thing we can do is, in `glib.h', say

	#ifndef G_DIR_SEPARATOR_S
	# define G_DIR_SEPARATOR_S "/"
	#endif

	#ifndef G_SEARCHPATH_SEPARATOR_S
	# define G_SEARCHPATH_SEPARATOR_S ":"
	#endif

	#define G_DIR_SEPARATOR		G_DIR_SEPARATOR_S[0]
	#define G_SEARCHPATH_SEPARATOR	G_SEARCHPATH_SEPARATOR_S[0]

and 

	#define G_DIR_SEPARATOR_S "\\"
	#define G_SEARCHPATH_SEPARATOR_S ";"

in glibconfig.h.win32.  The idea being to have fewer and fewer
occurances of `#ifdef WIN32' in `glib.h'.

- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash