Re: A small XIM patch again..

[Owen Taylor <otaylor redhat com>]

Changwoo Ryu <cwryu@adam.kaist.ac.kr> writes:

> Now gdk_im_begin() never calls XSetICFocus().  So some XIM servers,
> which depends on XIM_SET_IC_FOCUS message, don't work with GTK+.
> 
> I sent the patch a long before, but neither applied, rejected, nor
> discussed.  I'll commmit this by myself, if noone bothers.

This, I'm pretty certain is convered by gtk-matsu-9801109-patch,
which I'm in the process of integrating now. (I.e., it should
be done in the next few days).

So, please don't commit this right now.

Regards,
                                        Owen

 
> --- gdk.c~	Mon Dec  7 08:31:06 1998
> +++ gdk.c	Mon Dec  7 08:31:22 1998
> @@ -3298,7 +3298,6 @@
>    private = (GdkICPrivate *) ic;
>    
>    xim_using = TRUE;
> -  xim_ic = private;
>    xim_window = window;
>    if (gdk_im_ready())
>      {
> @@ -3307,7 +3306,10 @@
>  	XSetICValues (private->xic, XNFocusWindow, 
>  		      GDK_WINDOW_XWINDOW(window), NULL);
>        if (private != xim_ic)
> -	XSetICFocus (private->xic);
> +	{
> +	  xim_ic = private;
> +	  XSetICFocus (private->xic);
> +	}
>      }
>  }