Re: soft-drop-bug

[Christian Kröner <chris coroner web de>]

Am Donnerstag, 17. Juli 2003 01:38 schrieb James Antill:
> Dani Carbonell <bocata panete net> writes:
> > El mi? 16-07-2003 a las 21:57, Christian Kr~ner escribi~:
> > > dear developers,
> > > i noticed a bug in the recent version of gtetrinet, 0.7.3. in this
> > > version it is impossible to move the pieces while letting them fall
> > > down faster (hehe, im german, sorry for that bad english :D) i switched
> > > back to 0.7.2 and it was fine again... pls fix this for future
> > > versions...
> > > greets, coroner
> >
> > I can't reproduce this... I'm holding pressed the "down" key, the piece
> > falls faster, and I can move it around, rotate it, drop it, the special
> > keys work... can someone confirm this ??
>
>  Well one change I see is the addition of...
>
>     if ((key->state & (GDK_MOD1_MASK | GDK_CONTROL_MASK | GDK_SHIFT_MASK))
> > 0) return FALSE;
>
> ...with the comments of...
>
> small fix to the keypress signal handling (although it's a mess yet)
>
> ...and ChaneLog...
>
>         * src/gtetrinet.c (keypress): slightly changed the keypress signal
>         handling logic.
>
> ...but this means that if you set down to control left, say. Then it
> won't work. Christian ... do you have alt, control or shift as your
> down key?
>
>  Without holding down works ok, due to keyrelease() not having the
> same code.

hehe, well, youre right, i have set down to control left, but i think it 
should work too with every button you want to set it... so in my opinion this 
ought to be fixed for the next releases, doesnt it?