Re: [GnomeMeeting-list] [PATCH] Better integration with Video4Linux for PWLIB

[Derek Smithies <derek indranet co nz>]

Chris,
 Modifying kernel code, or adding module parameters, are a pain.
 You see, it means that anyone else who uses the QuickCam has to do the 
same.

Your patch is "fine", in that it works.
However, I really really don't want to add it, cause that will change the 
operation of the pwlib v4l code for all cameras.

Can I suggest that you modify your patch, so that it uses the hint table, 
line 200 of video4linux.cxx
Modify the hint table so it includes a section for your QuickCam camera.
and put a new hint in the hint table.

The new hint is
    HINT_USE_CURRENT_HARDWARE_SIZE 0x0400

Then,  you have in your changes.
if (HINT (HINT_USE_CURRENT_HARDWARE_SIZE)) {
   your code;
 } else {
    previous code;
 }


Thus, if the camera is QuickCam, it uses your code.
     if the camera is anything else, nothing changes.

Derek.

On Sun, 21 Sep 2003, Chris Rankin wrote:

> Hi,
> 
> I have been trying to get my QuickCam working with gnomemeeting 0.98.5 and 
> pwlib-1.5.3. The problem was that my camera was reporting a maximum frame size 
> of 640x480, which is only correct when compression is available. However, I'm 
> currently unable to use compression. This means that my maximum frame size is 
> actually 352x288 at 5 fps.
> 
> I'm not sure what the best fix(es) are, but this patch against pwlib works. The 
> idea is that the library reads the current hardware frame size instead of 
> assuming that the maximum size is OK. I can set the driver's default hardware 
> frame size and fps via module parameters, of course.
> 
> A second option is to modify the kernel module so that it reports a less 
> ambitious maximum frame size if no compression is available, and this doesn't 
> sound unreasonable either. I suppose that the ideal solution would involve both 
> these fixes.
> 
> Cheers,
> Chris
> 

-- 
Derek Smithies Ph.D.                           This PC runs pine on linux for email
IndraNet Technologies Ltd.                     If you find a virus apparently from me, it has
Email: derek indranet co nz                    forged  the e-mail headers on someone else's machine
ph +64 3 365 6485                              Please do not notify me when (apparently) receiving a
Web: http://www.indranet-technologies.com/     windows virus from me......