Re: [GnomeMeeting-list] [PATCH] No audio feedback in 0.98 config druid!!!

[Damien Sandras <dsandras seconix com>]

We have a problem here :

- either we apply the patch and people with a low volume (0) will think
that it doesn't work
- or we keep it and people with a good setup will hear sounds too loud
- or finally we add volume sliders in the druid and make it even bigger

I think I prefer the second solution...

Le dim 07/09/2003 à 13:12, Chris Rankin a écrit :
> Hi,
> 
> This patch will prevent further damage to my hearing. I have a SB Live! card 
> using OSS emulation under ALSA (no native ALSA support in gnomemeeting?) with 
> carefully adjusted mixer settings and I do NOT want the druid to just whack the 
> microphone up to 100 because this produces *atrocious feedback*!!!
> 
> Interestingly, according to the ALSA mixer, I don't need the microphone unmuted 
> at all (although I need one connected, of course!) and the important setting is 
> the AC97 Capture. The OSS mixer interface is a bit of a blunt instrument here.
> 
> I am now going to somewhere nice and quiet to recover. Like an airport runway.
> Cheers,
> Chris
> 
> ______________________________________________________________________
> --- gnomemeeting-0.98.0/src/sound_handling.cpp.orig	Sun Sep  7 11:59:11 2003
> +++ gnomemeeting-0.98.0/src/sound_handling.cpp	Sun Sep  7 11:59:53 2003
> @@ -383,7 +383,6 @@
>    char *buffer_play = (char *) malloc (8 * 1024);
>    char *buffer_record = (char *) malloc (8 * 1024);
>    char *buffer_ring = (char *) malloc (8 * 5 * 1024);
> -  char *mixer = NULL;
>    
>    int buffer_play_pos = 0;
>    int buffer_rec_pos = 0;
> @@ -399,13 +398,7 @@
>    memset (buffer_ring, 0, sizeof (buffer_ring));
>    memset (buffer_play, 0, sizeof (buffer_play));
>    memset (buffer_record, 0, sizeof (buffer_record));
> -
> -  mixer =
> -    gconf_client_get_string (client, DEVICES_KEY "audio_recorder_mixer", NULL);
> -  gnomemeeting_set_mixer_volume (mixer, SOURCE_MIC, 100);
> -  g_free (mixer);
> -
> -  
> + 
>    /* We try to open the 2 selected devices */
>    if (!player->Open (ep->GetSoundChannelPlayDevice (), PSoundChannel::Player,
>  		     1, 8000, 16)) {
-- 
 _	Damien Sandras
(o-	GnomeMeeting: http://www.gnomemeeting.org/
//\	FOSDEM 2003:  http://www.fosdem.org
v_/_	
	H.323 phone:  callto://ils.seconix.com/dsandras seconix com