Re: [GnomeMeeting-list] Cannot use FireWire cam with gnomemeeting

[Rob Roland <nvrrobx nvrrobx org>]

The patch works great!!!  Thanks!

   - Rob

Damien Sandras wrote:

> You have to apply the following patch (contributed by 2 users). It is
> not tested so you are a good way to test it.
> It will not be included in the next release because it is too late too
> integrate it before the release.
>
> Please report problems or success :)
>
> Le ven 10/01/2003 à 04:26, Rob Roland a écrit :
>  
>
> > Hi all,
> >
> > I've gotten the newest GnomeMeeting snapshot (2003-01-10) and compiled 
> > it.  My PWLib and OpenH323 were compiled with the TRY_1394DC=1 variable 
> > set, and:
> >
> > |ohphone -ln --videotest --videoreceive x11 --videodevice /dev/raw1394|
> >
> > works great, displaying the image from my cam.  GnomeMeeting doesn't 
> > have the camera listed as an input device, but I do see my bttv tuner 
> > card (/dev/video0).
> >
> > Are there extra patches that I need?  Here's my system / package info:
> >
> > Gentoo Linux 1.4rc2
> > OpenH323 1.11.2 (compiled with TRY_1394DC=1)
> > PWLib 1.4.7 (compiled with TRY_1394DC=1)
> > GnomeMeeting 2003-01-10
> >
> > Any help would be greatly appreciated!!
> >
> > Rob Roland
> >
> > _______________________________________________
> > GnomeMeeting-list mailing list
> > GnomeMeeting-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnomemeeting-list
> >    
> >
> > ------------------------------------------------------------------------
> >
> > Index: src/main_window.cpp
> > ===================================================================
> > RCS file: /cvs/gnome/gnomemeeting/src/main_window.cpp,v
> > retrieving revision 1.169
> > diff -u -r1.169 main_window.cpp
> > --- src/main_window.cpp	7 Jan 2003 10:23:12 -0000	1.169
> > +++ src/main_window.cpp	8 Jan 2003 02:03:38 -0000
> > @@ -1237,6 +1237,12 @@
> >   gw->audio_player_devices = gnomemeeting_get_audio_player_devices ();
> >   gw->audio_recorder_devices = gnomemeeting_get_audio_recorder_devices ();
> >   gw->video_devices = PVideoInputDevice::GetInputDeviceNames ();
> > +#ifdef TRY_1394DC
> > +  gw->video_devices += PVideoInput1394DcDevice::GetInputDeviceNames();
> > +#endif
> > +#ifdef TRY_1394AVC
> > +  gw->video_devices += PVideoInput1394AvcDevice::GetInputDeviceNames();
> > +#endif
> >   gw->audio_mixers = gnomemeeting_get_mixers ();
> >   
> >   gnomemeeting_init_pref_window ();  
> > Index: src/pref_window.cpp
> > ===================================================================
> > RCS file: /cvs/gnome/gnomemeeting/src/pref_window.cpp,v
> > retrieving revision 1.130
> > diff -u -r1.130 pref_window.cpp
> > --- src/pref_window.cpp	5 Jan 2003 00:29:57 -0000	1.130
> > +++ src/pref_window.cpp	8 Jan 2003 02:03:39 -0000
> > @@ -141,6 +141,12 @@
> >   
> >   /* The Video player */
> >   gw->video_devices = PVideoInputDevice::GetInputDeviceNames ();
> > +#ifdef TRY_1394DC
> > +  gw->video_devices += PVideoInput1394DcDevice::GetInputDeviceNames();
> > +#endif
> > +#ifdef TRY_1394AVC
> > +  gw->video_devices += PVideoInput1394AvcDevice::GetInputDeviceNames();
> > +#endif
> >   gnomemeeting_update_pstring_option_menu (dw->video_device,
> > 					   gw->video_devices,
> > 					   DEVICES_KEY "video_recorder");
> > Index: src/videograbber.cpp
> > ===================================================================
> > RCS file: /cvs/gnome/gnomemeeting/src/videograbber.cpp,v
> > retrieving revision 1.78
> > diff -u -r1.78 videograbber.cpp
> > --- src/videograbber.cpp	6 Jan 2003 23:31:51 -0000	1.78
> > +++ src/videograbber.cpp	8 Jan 2003 02:03:40 -0000
> > @@ -460,7 +460,22 @@
> >     
> >     channel = new PVideoChannel ();
> >     encoding_device = new GDKVideoOutputDevice (1, gw);
> > -    grabber = new PVideoInputDevice();
> > +#ifdef TRY_1394AVC
> > +    if (video_device == "/dev/raw1394" ||
> > +    	strncmp (video_device, "/dev/video1394", 14) == 0) {
> > +	     grabber = new PVideoInput1394AvcDevice();
> > +	}
> > +    else
> > +#endif
> > +#ifdef TRY_1394DC
> > +    if (video_device == "/dev/raw1394" ||
> > +        strncmp (video_device, "/dev/video1394", 14) == 0)
> > +	    grabber = new PVideoInput1394DcDevice();
> > +    else
> > +#endif
> > +	{
> > +	    grabber = new PVideoInputDevice();
> > +	}
> >
> >     if (video_size == 0) { 
> >       
> > @@ -484,7 +499,10 @@
> >       if (!grabber->Open (video_device, FALSE))
> > 	error_code = 0;
> >       else
> > -	if (!grabber->SetVideoChannelFormat (video_channel, video_format))
> > +	if (!grabber->SetVideoFormat(PVideoDevice::Auto))
> > +	  error_code = 2;
> > +      else
> > +        if (!grabber->SetChannel(video_channel))
> >           error_code = 2;
> >       else
> > 	if (!grabber->SetColourFormatConverter ("YUV420P"))
> >