Re: [GnomeMeeting-devel-list] gmcontacts.h, struct _GmContact



Jan Schampera a écrit :
EHLO,

The member _GmContact.state is defined like:
  int  state;                   /* Status of the user:
                                        0: available
                                        1: do not disturb/busy
                                        2: auto answer
                                        3: forward
4: called 5: offline
                                */

Isn't that worth an enum{}? I'm just afraid to add one, as this is so
obvious, that I tend to think it wasn't added because of a good reason
(or it's done elswhere).

It is worth an enum. Magic values are evil. I'll open a bug report about this one too (I already have http://bugzilla.gnome.org/show_bug.cgi?id=330525 in sight)

Snark



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]