Re: [GnomeMeeting-devel-list] Re: Opal "make install" broken

[Peter Robinson <pbrobinson gmail com>]

The problem I was finding, and I'm open to ideas on this as its very
new to me, was that the OPAL build was clobbering the real libdir
anyway. Part of the script was changing it to buildlocation/lib. I
found this out the hard way by putting series of echo through out the
build script. In the process of trying to fix it to use LIBDIR
properly (based on some examples I had inc the openh323 build and the
pwlib build) it was then breaking the actual build of the library so I
was finding it a double edged sword. As Craig has said in the past,
the OPAL build system is currently a second class citizen compared to
its other conterparts (pwlib and openh323). I originally submitted a
patch to the bug tracker for review and it got committed. The second
patch was an attempt to fix that but this is my first real attempt
into serious make file hacking so I'd apreciate any help you can give
me.

Regards
Peter


On 4/22/05, Georgi Georgiev <chutz gg3 net> wrote:
> maillog: 21/04/2005-17:47:19(+0100): Peter Robinson types
> > --- opal-clean/Makefile.in    2005-04-22 00:21:10.000000000 +0800
> > +++ opal/Makefile.in  2005-04-22 00:23:29.000000000 +0800
> > @@ -714,13 +714,13 @@
> >                    $(DESTDIR)$(PREFIX)/share/opal ;\
> >               do mkdir -p $$dir ; chmod 755 $$dir ; \
> >       done)
> > -     $(INSTALL) -m 755 lib/$(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION).$(BUILD_NUMBER) $(DESTDIR)$(LIBDIR)
> > +     $(INSTALL) -m 755 lib/$(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION).$(BUILD_NUMBER) $(DESTDIR)$(PREFIX)lib
> 
> Dude, why did you change LIBDIR to PREFIX/lib... this would break stuff
> on my system, where I prefer to put 64-bit libs in /lib64 and 32-bit in
> /lib32.
> 
> I'm sorry I didn't follow the thread, but this doesn't seem like a
> solution to me.
> 
> >       ln -snf $(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION).$(BUILD_NUMBER) \
> > -             $(DESTDIR)$(LIBDIR)/$(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION)
> > +             $(DESTDIR)$(PREFIX)lib/$(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION)
> >       ln -snf $(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION).$(BUILD_NUMBER) \
> > -             $(DESTDIR)$(LIBDIR)/$(OPAL_FILE).$(MAJOR_VERSION)
> > +             $(DESTDIR)$(PREFIX)lib/$(OPAL_FILE).$(MAJOR_VERSION)
> >       ln -snf $(OPAL_FILE).$(MAJOR_VERSION).$(MINOR_VERSION).$(BUILD_NUMBER) \
> > -             $(DESTDIR)$(LIBDIR)/$(OPAL_FILE)
> > +             $(DESTDIR)$(PREFIX)lib/$(OPAL_FILE)
> >       ( for fn in include/asn/*.h ; do \
> >               $(INSTALL) -m 644 $$fn $(DESTDIR)$(PREFIX)/include/opal/asn ; \
> >       done)
> > @@ -751,10 +751,10 @@
> >       $(INSTALL) -m 644 opal_inc.mak $(DESTDIR)$(PREFIX)/share/opal
> >
> >  uninstall:
> > -     rm -rf $(DESTDIR)$(PREFIX)/include/opal \
> > -            $(DESTDIR)$(PREFIX)/share/opal
> > -     rm -f $(DESTDIR)$(LIBDIR)/$(OPAL_FILE) \
> > -           $(DESTDIR)$(LIBDIR)/libopal.so
> > +     rm -rf $(DESTDIR)$(PREFIX)include/opal \
> > +            $(DESTDIR)$(PREFIX)share/opal
> > +     rm -f $(DESTDIR)$(PREFIX)lib/$(OPAL_FILE)* \
> > +           $(DESTDIR)$(PREFIX)lib/libopal.so
> >
> >
> >  docs:
> 
> > --- opal-2.1.0-clean/version.h        2005-02-21 15:12:21.000000000 +0800
> > +++ opal-2.1.0/version.h      2005-02-21 15:53:20.573765724 +0800
> > @@ -36,7 +36,7 @@
> >
> >  #define MAJOR_VERSION 2
> >  #define MINOR_VERSION 1
> > -#define BUILD_TYPE    BetaCode
> > +#define BUILD_TYPE    ReleaseCode
> >  #define BUILD_NUMBER 1
> 
> --
> (    Georgi Georgiev   (  To follow foolish precedents, and wink With  (
> )    chutz gg3 net     ) both our eyes, is easier than to think. -     )
> (   +81(90)2877-8845   (  William Cowper                               (
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
>