Re: [GnomeMeeting-devel-list] [PRE-PATCH] private calls history



I will investigate on this patch this week end, I would just try to get
rid of is_model_from_calls_history.


Le lun 26/01/2004 à 20:59, PUYDT Julien a écrit :
> Hi,
> 
> this pre-patch makes GmCallsHistoryWindow private.
> 
> Why isn't it a patch?
> 1) I don't like the function I had to add... neither its name nor its
> principle ;
> 2) I didn't comment it properly ;
> 3) I'm wondering if I shouldn't also take all calls-history related
> code, and stuff it into calls_history_window.*
> 
> Any opinion?
> 
> Snark
> 
> PS: it is compatible with private_text_chat.patch
-- 
 _      Damien Sandras
(o-     
//\     It-Optics s.a.
v_/_    GnomeMeeting: http://www.gnomemeeting.org/
        FOSDEM 2004:  http://www.fosdem.org
        H.323 phone:  callto:ils.seconix.com/dsandras seconix com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]