Re: [GnomeMeeting-devel-list] [PATCH] vfakeio modification



On lun, 2004-02-09 at 20:47, Stefan Bruens wrote:
> This case is covered by 
> if ((unsigned)orig_width <= width && (unsigned)orig_height <= height)

Yes, see the comment in the new version ;-)

> The result of all the code fragments is exactly the same (as you are only 
> interested in the value of scale, not scale_h nor scale_w).

Indeed, I had missed that point, and you drove it home :-)

> PS: Even your version should result in the same code if you have a _really_ 
> good compiler.

Agreed.

Thanks,

Snark

PS: in fact, rereading your mail, I see it is exactly the code you
proposed! I just wrote the same without noticing, with only a comment
added to make the purpose clearer...




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]