Re: [GnomeMeeting-devel-list] [PATCH] more private druid



Le jeu, 29/04/2004 à 15:17 +0200, PUYDT Julien a écrit :
> On jeu, 2004-04-29 at 14:56, Damien Sandras wrote:
> 
> > Don't use things like this :
> > +  dw = (GmDruidWindow *)g_object_get_data (G_OBJECT
> > (GnomeMeeting::Process ()->GetDruidWindow ()), "GMObject");
> > Put the data as data of the GtkWidget *druid_window, put that
> > druid_window in GmWindow * and call the get_data thing only in
> > druid_window.cpp.
> 
> I can't call the get_data only in src/druid.cpp yet:
> src/sound_handling.cpp and src/videograbber.cpp still need it. I think
> I'll make some sort of void

Having GtkWidget *druid_window in GmWindow would solve that.

> gnomemeeting_druid_set_test_buttons_sensitivity (GtkWidget *, gboolean)
> to take care of this. Do you like that? (feel free to provide a better
> name for that function!)

That's ok if druid_window (the GTK WIDGET) is the first argument.

> 
> And even in druid.cpp, I don't like the idea to have to call
> GnomeMeeting::Process ()->GetDruidWindow (), most of the calls should
> just get the GtkWidget* as first argument.
> 

indeed, that is the ultimate goal.

> As I said, this is only a beginning...
> 
> Snark
> 
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list

Attachment: signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]