Re: proposed asynchronous gnome_vfs_url_show implementation waiting for review

On Fri, 2006-06-30 at 12:35 +0200, Christian Neumair wrote:
> See
> We need this both for the Panel and for Nautilus.

I had a quick look at this, and I see some problems.
First, the code is using GnomeVFSURIs to pass around the uris to the
async thread. This will not work well, becauser gnome_vfs_url_show() is
typically used for things that are not gnome-vfs uris such as mailto:.

Secondly, the way gnome_vfs_url_show handles the url handler for such
urls is not threadsafe. In fact, since it calls gconf directly it might
even cause a corba call and recurse into random corba functions in the
async thread.

_gnome_vfs_cmd_matches_cmdline is totally linux-specific. Also, i don't
get the whole use for this. Launching e.g. nautilus from nautilus is not
a huge problem (it'll be handled by the single-instance code) and is in
fact something that happens at times.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an immortal arachnophobic senator with a robot buddy named Sparky. She's 
a beautiful red-headed mechanic in the witness protection program. They fight 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]