Re: [PATCH] Make gnome_vfs_make_uri_from_input_internal more robust
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: gnome-vfs-list <gnome-vfs-list gnome org>
- Subject: Re: [PATCH] Make gnome_vfs_make_uri_from_input_internal more robust
- Date: Mon, 27 Feb 2006 11:05:40 +0100
On Fri, 2006-02-24 at 17:33 +0100, Christian Neumair wrote:
> The attached patch is meant to "fix" bug 329781 [1] by making
> gnome_vfs_make_uri_from_input_internal a bit more robst. I don't like
> the route we currently go, i.e. we just guess based on the string
> instead of using GnomeVFSURIs, but it's probably too late in the cycle
> to change that. The function might need some more love and URI sanity
> checking, but the attached patch did the trick for me.
>
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=329781
What does the first part do? We check for a dot in the code below anywa,
so it seems unnecessary.
For the second part, I made a slighly simpler fix by just always adding
file:/// instead of file:// (we know the string doesn't start with /
anyway).
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's an ungodly Amish hairdresser with acid for blood. She's a blind
nymphomaniac Valkyrie trying to make a difference in a man's world. They fight
crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]