Re: [patch] use gnome-mount for unmounting, ejecting floppy, IDE zip drive etc



On Wed, 2006-02-22 at 16:17 +0100, Christian Neumair wrote:
> Am Dienstag, den 21.02.2006, 13:02 -0500 schrieb David Zeuthen:
> > +#if defined(USE_GNOME_MOUNT)
> > +               /* Volumes from drives that are not polled may not
> > +                * have a hal_udi.. take the one from HAL to get
> > +                * gnome-mount working */
> > +               if (hal_udi == NULL) { 
> 
> Is there any reason for making this specific to gnome-mount? It also
> controls the invocation of HAL_EJECT in mount_unmount_thread.

I suppose it's not really specific to gnome-mount no.. not sure what
other mount helpers would benefit though.. I think gnome-mount is the
only one that uses the HAL UDI...

Want me to commit without the #ifdef USE_GNOME_MOUNT?

Thanks,
David





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]