Re: [PATCH] modify find_cached_server string semantics

[Alexander Larsson <alexl redhat com>]

On Thu, 2006-03-30 at 15:10 +0000, Nate Nielsen wrote:
> Christian Neumair wrote:
> > Am Mittwoch, den 29.03.2006, 09:58 +0200 schrieb Philippe Normand:
> > 
> >>Hi,
> >>
> >>I'm browsing a local Samba share using either
> >>nautilus or gnome-python gnomevfs package.. It works like a charm
> >>excepted that my samba server forks *lots* of process, and these
> >>connections are never closed. I ended with about 200 smbd processes, and
> >>a loadavg of 195 ...
> >>
> >>If i try to browse my share using smbclient, smbd forks one process
> >>which is killed when i exit smbclient. This makes me think there could
> >>be a bug in GnomeVFS SMB module.. What's your opinion ?
> >>
> >>What can i do to help solve the problem ? I'm using Gnome 2.14.
> > 
> > I haven't ever touched the smb method, but I could reproduce your issue
> > and tried to fix it by making find_cached_server use similar string
> > semantics as add_cached_server. After applying it, the cache lookup WFM
> > as expected and the smbd spawning paranoia stops.
> 
> The patch makes sense.
> 
> Although, the SMB module does try to enforce the "" = NULL on its
> strings everwhere, obviously we're dropping the ball somewhere.
> 
> If a module maintainer agrees, I'd say we should commit this.

Yes. Please commit to HEAD and gnome-2-14.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a time-tossed hunchbacked rock star with no name. She's a mentally 
unstable nymphomaniac Hell's Angel with the power to see death. They fight 
crime!