Re: [PATCH] Fix heavily broken relative URI resolution
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: gnome-vfs-list gnome org
- Subject: Re: [PATCH] Fix heavily broken relative URI resolution
- Date: Thu, 20 Apr 2006 16:44:51 +0200
On Thu, 2006-04-20 at 16:03 +0200, Alexander Larsson wrote:
> On Sun, 2006-03-19 at 17:06 +0100, Christian Neumair wrote:
> > > I don't know WHY many modules and applications use
> > > gnome_vfs_uri_resolve_relative, they usually shouldn't have to mess
> > > around with this and instead use a symlink resolution helper - maybe
> > > because the old docs claim it has something to do with relative path
> > > resolution, which is only right to a point where the relative URI only
> > > forms a path with segments that exclusively contain unreserved
> > > characters.
> Yeah, we should be using a specific symlink resolver in some places
> instead of resolve_relative.
Actually, isn't this OK? I mean, the relative path should be escaped, so
it won't have any reserved characters.
For instance, this is what nautilus does in
file_uri = nautilus_file_get_uri (file);
escaped_name = gnome_vfs_escape_path_string
target = gnome_vfs_uri_make_full_from_relative
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a fast talking umbrella-wielding cyborg in a wheelchair. She's a
green-fingered motormouth archaeologist who inherited a spooky stately manor
from her late maiden aunt. They fight crime!
] [Thread Prev