Re: [PATCH] Fix FTP/SFTP authentication cancellation

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-10-18 at 17:17 +0200, Christian Neumair wrote:
> Am Dienstag, den 18.10.2005, 09:57 +0200 schrieb Alexander Larsson:
> > On Mon, 2005-10-17 at 20:45 +0200, Christian Neumair wrote:
> > > Am Montag, den 17.10.2005, 13:09 +0200 schrieb Alexander Larsson:
> > > >  static gboolean
> > > > -prompt_authentication (SmbAuthContext *actx)
> > > > +prompt_authentication (SmbAuthContext *actx,
> > > > +                      gboolean       *cancelled)
> > > > 
> > > > This isn't fixing all uses of the old non-pointer cancelled variable.
> > > > (In particular, it breaks the return value at the end.)
> > > 
> > > Eeek, I sent an old revision. I´ve actually changed the latter in a
> > > later revision.
> > > 
> > > This one additionally initializes cancelled to FALSE in
> > > prompt_authentication (gcc 4 complains, gcc 3 not), and improves the
> > > previously bogus DEBUG_SMB macro invocations in perform_authentication.
> > 
> > It still looks the same. prompt_authentication() uses the the cancelled
> > pointer without dereferencing it
> 
> Dunno why this isn't in the patch. It was in my local tree.
> 
> > and doesn't initialize it.
> 
> Well, it is IMHO only meant to be valid if invoked is TRUE. However,
> I've changed it to match the semantics of the other modules.

Looks good to commit.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a benighted playboy paramedic possessed of the uncanny powers of an 
insect. She's a beautiful impetuous mechanic in the wrong place at the wrong 
time. They fight crime!