Re: [PATCH] Fix GnomeVFS LS parser

[Alexander Larsson <alexl redhat com>]

On Fri, 2005-10-14 at 22:51 +0200, Christian Neumair wrote:
> OK, the GnomeVFS ls -lga parser is seriously hosed by only handling one
> filename at a time, but that's a different topic.
> The attached patch fixes bug 163671 [1]. It makes GnomeVFS pass all
> "test-parse-ls-lga" tests, and even display files named like a time or
> like a year correctly in FTP directories, which was a bit tricky, since
> the FTP module didn't split the string at '\n' characters before passing
> it to the parser. However, since the API suggests that
> gnome_vfs_parse_ls_lga can parse multiple lines ([2]), I've preferred to
> add multiline detection semantics to the latter.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=163671
> [2] which is - I repeat - NOT true as of writing, it only sets the first
> member of the passed-in filename array

I'm not sure why you think the filename argument is an array. Its just a
normal out-parameter.

Furthermore, it looks like this is not a full patch. vfs_parse_filedate
adds more arguments, but the calls to it are not changed.

I'm gonna commit the tests.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a globe-trotting guitar-strumming cyborg gone bad. She's a plucky 
African-American Valkyrie with an incredible destiny. They fight crime!