Re: path for #304022: sftp-method confuse SSH2_FX and GNOME_VFS codes



On Sun, 2005-07-17 at 23:13 +0200, Sebastien Bacher wrote:
> Hi,
> 
> 
> The bug http://bugzilla.gnome.org/show_bug.cgi?id=304022 is about
> gnome_vfs_async_open_uri returning GNOME_VFS_ERROR_EOF instead of
> SSH2_FX_NO_SUCH_FILE with the sftp method.
> 
> This is because the code does:
> 
> "sftp_res = iobuf_read_handle (conn->in_fd, &sftp_handle, id, (guint32
> *)&sftp_handle_len);
> 
> if (sftp_res == SSH2_FX_OK) {
> ...
> return sftp_status_to_vfs_result (sftp_res);"
> 
> but iobuf_read_handle () returns a GnomeVFSResult, so the
> comparaison/conversion are wrong. The patch fixes the issue.

Good catch.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an otherworldly amnesiac vagrant on the hunt for the last specimen of a 
great and near-mythical creature. She's a provocative French-Canadian single 
mother with an evil twin sister. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]