Re: [Utopia] Re: [patch] improved hal support for gnome-vfs

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-07-07 at 15:19 -0400, David Zeuthen wrote:
> Hi,
> 
> On Fri, 2005-07-01 at 23:01 -0400, David Zeuthen wrote: 
> 
> (I shouldn't be writing patches that late in the night especially just
> before going on vacation :-)
> 
> > > This doesn't work. First of all, drives and volumes, once initialized
> > > are generally read-only (except the volume-drive relationships). This is
> > > partly a threading issue, as all thread protection on these datatypes is
> > > based on them being read-only. It also lacks any code to push such
> > > changes from the daemon to the clients, so nobody will actually see this
> > > change.
> > 
> > Right, sorry, I should have deleted this code. Now we just delete the
> > drive if it was already there and then add a new one.
> 
> OK, this did make gnome-vfs-daemon crash especially after the reprobe()
> that happens after e.g. mount. Since any code shouldn't be relying on
> the activation_uri of the GnomeVFSDrive (instead, use the activation_uri
> of the associated volume) we just reuse the GnomeVFSDrive object without
> updating the activation_uri at all. 
> 
> I also forgot to query for vendor provided icons.
> 
> Both things are fixed in the attached patch. May I commit this?

Sure.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a one-legged crooked shaman on the edge. She's a cold-hearted junkie cab 
driver with an incredible destiny. They fight crime!