[PATCH] Supress eroneous authentications in the SMB module
- From: Nielsen <nielsen memberwebs com>
- To: "gnome-vfs-list gnome org" <gnome-vfs-list gnome org>
- Subject: [PATCH] Supress eroneous authentications in the SMB module
- Date: Tue, 15 Feb 2005 09:41:07 +0000 (GMT)
-----BEGIN PGP SIGNED MESSAGE-----
The new authentication code in the SMB module has a prompting issue. Any
time it encounters a EPERM or EACCES it tries to authenticate and throws
up a prompt (when no cached authentication is available or it fails).
This unabashed lust for authentication leads to some problems. For
example open an SMB share that you only have read-only access to. Now
try to rename a file. You'll get a prompt for a user name and password
instead of the expected error message. I guess this could make sense in
a twisted sort of way but it's probably not what the user is expecting.
I'd like to get this fixed before Gnome 2.10. Attached is a patch. This
patch makes the assumption that if we already have a cached connection
then there's no point in trying to reprompt the user for more
credentials. Before committing I'd like to see if anyone thinks this
assumption is an invalid one.
PS: This will fix bugs that look like:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
-----END PGP SIGNATURE-----
] [Thread Prev