Re: Offset problem in the ftp module

[Marcus Bjurman <marcus softish se>]

Hi,

I have tried your attached patch and it works OK. Let's forget about my
patch and use this one instead.

/Marcus

On Sun, 2004-05-16 at 12:53, Christophe Fergeau wrote:
> Hi,
> 
> I don't know the ftp method very well either, but I tend to agree with
> Alex, ie I'd fix that with the attached patch. See also
> http://bugzilla.gnome.org/show_bug.cgi?id=140583
> 
> Cheers,
> 
> Christophe
> 
> Le mer, 12/05/2004 à 16:07 +0200, Alexander Larsson a écrit :
> > On Tue, 2004-05-04 at 20:49, Marcus Bjurman wrote:
> > 
> > > I'm not sure if my patch solves the real problem or just deals with the
> > > symptoms of something else. If it is a real solution I'm willing to
> > > create a new patch that moves the detection of the 226 code and the
> > > reset of the offset variable to a more suitable place then in the
> > > ftp_response_to_vfs_result function. That will require a little more
> > > work though due to the current handling of response codes in the
> > > ftp-module.
> > 
> > I don't know ftp very well, but i took a look at this. Shouldn't we just
> > make sure to set offset to zero in ftp_connection_acquire()? Or will
> > that break something?
> > 
> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> >  Alexander Larsson                                            Red Hat, Inc 
> >                    alexl redhat com    alla lysator liu se 
> > He's an ungodly arachnophobic cowboy trapped in a world he never made. She's a 
> > manipulative insomniac bodyguard from Mars. They fight crime! 
> > 
> > _______________________________________________
> > gnome-vfs-list mailing list
> > gnome-vfs-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
> > 
> > 
> 
> ______________________________________________________________________
> _______________________________________________
> gnome-vfs-list mailing list
> gnome-vfs-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-vfs-list