Re: [Utopia] gnome-vfs HAL patch, take 3

On Tue, 2004-07-13 at 20:15, David Zeuthen wrote:
> On Fri, 2004-07-09 at 11:26 +0200, Alexander Larsson wrote:
> > What about the attached (untested) gnome-vfs-export-hal-udi.patch? It
> > exports the hal udi as a string, whenever its availible. This lets
> > nautilus recover UDI information from computer:// since the Drive/Volume
> > id is availible in the desktop files there. This would make it easy to
> > do things like adding emblems in nautilus.
> > 
> Ok, I just tried your patch, a slightly modified version is attached
> with a ChangeLog entry for the changes. 

Cool. I checked it in.

> Btw, one potential problem I've noticed is that by linking with
> libgnomevfs then libhal is dragged in as well, e.g.
>  [davidz ixus davidz]$ which nautilus
>  /opt/gnome2/bin/nautilus
>  [davidz ixus davidz]$ strace nautilus 2> /tmp/nout 

Heh, you can use strace -o nautilus.log nautilus

>  [davidz ixus davidz]$ cat /tmp/nout |grep libhal
>  open("/opt/gnome2/lib/", O_RDONLY) = -1 ENOENT (No such file or directory)
>  open("/opt/gnome2/lib/", O_RDONLY) = -1 ENOENT (No such file or directory)
>  open("/usr/lib/", O_RDONLY)  = 3
> and /opt/gnome2/bin/nautilus doesn't explicitly link with libhal. This
> doesn't look right, does it?

Thats not surprising, nautilus links to libgnomevfs, and libgnomevfs to
libhal, so it gets pulled in due to the DT_NEEDED. Is this a problem

It might be possible to move the daemon side code out of the core
gnome-vfs library though.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding playboy matador from the 'hood. She's a cold-hearted 
cat-loving widow prone to fits of savage, blood-crazed rage. They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]