Re: [Utopia] gnome-vfs HAL patch, take 3

[Kay Sievers <kay sievers vrfy org>]

On Thu, 2004-07-08 at 23:45 +0200, David Zeuthen wrote:
>  http://freedesktop.org/~david/gnome-vfs-take3-1.png
> 
> 
> 
> This screenshot shows another configuration with Firewire disks and a
> USB based Card Reader for Compact Flash. It also shows all of the icons
> mentioned
> 
>  http://freedesktop.org/~david/gnome-vfs-take3-2.png

Cool, looks great. Nice job, David.

> +	/* bail out if fstype is swap */
> +	if (hal_vol->fstype != NULL && strcmp (hal_vol->fstype, "swap") == 0)
> +		goto out;
> +

Hmm, what about the other unmountable volume types, like the
mac_partition_map, ...? Shouldn't we add a attribute to HAL like
'not_mountable' or just set 'is_mounted = -1', or something similar, so
HAL gets the control over the browser list and there is no need to
update the blacklist in gnome-vfs?

Thanks,
Kay