Re: [PATCH] plugs GnomeVFSSocket leaks in ftp/http method



On Fri, 2004-01-30 at 03:00, Thomas Cataldo wrote:
> Hi,
> 
> The attached patch was made after some valgrind/gnomevfs-(cat|ls) tests
> agains ftp and http urls.
> 
> By the way, as my previous patch against the nntp method was not
> reviewed, could you tell me if this list is the right place to send
> patches, or if a bug report is a better way.

This wasn't totally right. The free should be in gnome_vfs_socket_close
not in gnome_vfs_socket_buffer_destroy (or other users of GnomeVFSSocket
would leak). I commited that instead.

Thanks.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a jaded shark-wrestling shaman haunted by an iconic dead American 
confidante She's a scantily clad French-Canadian barmaid with a knack for 
trouble. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]