Re: api duplication
- From: murrayc t-online de (Murray Cumming)
- To: Alexander Larsson <alexl redhat com>
- Cc: Christophe Fergeau <teuf users sourceforge net>, gnome-release-team <release-team gnome org>, gnome-vfs-list gnome org
- Subject: Re: api duplication
- Date: 29 Jan 2003 09:58:11 +0100
On Wed, 2003-01-29 at 10:11, Alexander Larsson wrote:
> On 28 Jan 2003, Christophe Fergeau wrote:
>
> > Hi,
> >
> > As pointed out by http://bugzilla.gnome.org/show_bug.cgi?id=104532
> > gnome-vfs 2.2.0 introduced 2 duplicated functions:
> > gnome-vfs-uri.h:gnome_vfs_uri_make_full_from_relative
> > gnome-vfs-utils.h:gnome_vfs_make_uri_full_from_relative
> >
> > The one from gnome-vfs-uri.h has been there for a long time, while the
> > one in gnome-vfs-utils.h was added in gnome-vfs 2.2.0 Imo this function
> > should really be removed as soon as possible (before the release of
> > gnome 2.2) if that's still doable wrt to the freezes.
> > I diffed the 2 functions, and they are exactly the same, moreover, I
> > grepped for the new function (gnome_vfs_make_uri_full_from_relative) on
> > my whole gnome22 tree, and it's only called from gnome-vfs-utils.c
>
> The gnome-vfs-utils one was added by James Willcox when he was moving eel
> vfs functions to gnome-vfs.
>
> > What do you think about contacting the release team to try to remove
> > this function before the official gnome2.2 release ?
>
> Yeah. This might be a good idea.
>
> release-team: What's your opinion of this?
Personally I like this kind of thing, but I expect to be the only one
because API changes of any kind are very very scary during a deep code
freeze.
--
Murray Cumming
murray usa net
www.murrayc.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]