Re: removal of duplicated code in gnome-vfs-uri



> 
> This looks fine to commit. The only change in behaviour is the replacement 
> of g_return_val_if_fail() with normal comparisons in some edge cases (used 
> to be in make_full_uri_from_relative). g_return_val_if_fail() prints out a 
> warning if it fails and G_DISABLE_CHECKS is not defined. Maybe we should 
> add that back?

Ah, I didn't really know that it displayed a message. I'll add some
g_warning in the appropriate places (I guess they will have the same
behaviour as g_return_if_fail)

Christophe

Attachment: signature.asc
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]