Re: missing(?) g_free in vfolder-method.c [patch]

[Alexander Larsson <alexl redhat com>]

On 4 Feb 2003, paolo borelli wrote:

> While reading vfolder-method.c trying to figure out how it works ;) I
> noticed that in the function get_file_info_internal() in the first "if"
> branch file_info->mime_type and ->name are freed before the new value is
> strdup'ed, but in the other branch (which calls
> fill_file_info_for_directory() ) they are not.
> 
> Can someone who actually understands the code review and, if needed,
> apply the attached patch?

I wouldn't call these leaks as such. It seems to be generally in line 
with what gnome-vfs does. If you re-use GnomeVFSFileInfo objects you are 
required to call gnome_vfs_file_info_clear() on them.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a suave moralistic jungle king searching for his wife's true killer. 
She's a cynical thirtysomething former first lady on her way to prison for a 
murder she didn't commit. They fight crime!