Re: need some review

[Alexander Larsson <alexl redhat com>]

On 19 Dec 2002, Michael Meeks wrote:

> Hi Alex,
> 
> On Wed, 2002-12-18 at 12:30, Alexander Larsson wrote:
> > I just checked in the attached patch. It fixes a bad data-loss bug 
> > related to moving files over one of their parent directories.
> > (http://bugzilla.gnome.org/show_bug.cgi?id=99346)
> > 
> > The patch should be safe in itself, but I would like if someone verified 
> > that I didn't miss any way to get data loss.
> 
> 	The patch looks excellent from my (albeit brief) glance - it's great to
> have someone fixing bugs sanely. It looks as if it might still prompt
> the user about replacing the file (with itself) - is that a feature ?

You do get the initial "replace or skip" dialog, but if you pick replace 
it will fail with a nice error. We don't want to do the check before the 
first dialog because a) the user might want to skip it, b) that would be 
terribly slow.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a notorious guitar-strumming matador in drag. She's a mistrustful 
tempestuous safe cracker from out of town. They fight crime!