Re: patch: stream leak fix



On 4 Dec 2002, Frederic Crozat wrote:

> Hi,
> 
> while trying to fix a monitoring problem for gnome-vfs mime user dir, I
> found what I think is a stream leak in both write_back_keys_user_file
> and write_back_mime_user_file..
> 
> Can I commit the attached patch (with changelog entry, of course..) ?

I think a better solution is to make ensure_user_directory_exist() return 
a gboolean and closedir() itself, since no users actually use the DIR *.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a war-weary chivalrous boxer with a secret. She's a foxy punk Valkyrie 
operating on the wrong side of the law. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]