Re: [GNOME VFS] fixing module names

[Maciej Stachowiak <mjs noisehavoc org>]

On 04Sep2001 06:01PM (-0400), jacob berkman wrote:
> this patch fixes some stuff that will be broken on hp-ux.  i did try the
> test-xfer with it, which worked correctly.

Change looks great for gnome-vfs HEAD. It's OK for the stable branch
too as long as module .conf files in teh old format will still work (I
am not sure if g_module_build_path will work right in that case).
 
> the backend stuff also needs to call g_module_build_path(), but if they
> are getting merged we don't need it.
> 

If we end up not having time to kill all the backend stuff this may
need to be fixed

> jacob
> -- 
> "OOH!!!  Look at me!!  I'm Jacob Berkman!  I have a witty .signature
>  that nobody fully appreciates but myself!!"  -- Anonymous
> 
> ? libgnomevfs/gnome-vfs-metafile-server-common.c
> ? libgnomevfs/gnome-vfs-metafile-server-skels.c
> ? libgnomevfs/gnome-vfs-metafile-server-stubs.c
> ? libgnomevfs/gnome-vfs-metafile-server.h
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/ChangeLog,v
> retrieving revision 1.1105
> diff -u -r1.1105 ChangeLog
> --- ChangeLog	2001/09/04 05:08:55	1.1105
> +++ ChangeLog	2001/09/04 21:59:48
> @@ -1,3 +1,11 @@
> +2001-09-04  jacob berkman  <jacob ximian com>
> +
> +	* modules/*.conf: remove lib prefix and .so suffix from the
> +	libraries as g_module_build_path() will add these for us
> +
> +	* libgnomevfs/gnome-vfs-method.c (load_module_in_path_list): use
> +	g_module_build_path() to correctly get library suffix
> +
>  2001-09-03  Maciej Stachowiak  <mjs noisehavoc org>
>  
>  	Put gnome-vfs-backend stuff all in one header and make it private.
> Index: libgnomevfs/gnome-vfs-method.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-method.c,v
> retrieving revision 1.21
> diff -u -r1.21 gnome-vfs-method.c
> --- libgnomevfs/gnome-vfs-method.c	2001/08/03 19:03:19	1.21
> +++ libgnomevfs/gnome-vfs-method.c	2001/09/04 21:59:48
> @@ -260,7 +260,7 @@
>  		gchar *name;
>  
>  		path = p->data;
> -		name = g_strconcat (path, "/", base_name, NULL);
> +		name = g_module_build_path (path, base_name);
>  
>  		load_module (name, method_name, args, method, transform);
>  		g_free (name);
> Index: modules/cdda-module.conf
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/cdda-module.conf,v
> retrieving revision 1.1
> diff -u -r1.1 cdda-module.conf
> --- modules/cdda-module.conf	2001/03/16 01:38:04	1.1
> +++ modules/cdda-module.conf	2001/09/04 21:59:48
> @@ -1 +1 @@
> -cdda: libcdda.so
> +cdda: cdda
> Index: modules/default-modules.conf
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/default-modules.conf,v
> retrieving revision 1.23
> diff -u -r1.23 default-modules.conf
> --- modules/default-modules.conf	2001/06/10 20:08:11	1.23
> +++ modules/default-modules.conf	2001/09/04 21:59:48
> @@ -6,29 +6,29 @@
>  # <method 1> <method 2> ... <method N> : <module.so>
>  #
>  
> -bzip2: libbzip2.so
> +bzip2: bzip2
>  
> -cdda: libcdda.so
> +cdda: cdda
>  
> -file: libfile.so
> +file: file
>  
> -test: libvfs-test.so
> +test: vfs-test
>  
> -ftp: libftp.so
> +ftp: ftp
>  
> -gconf: libgconf.so
> +gconf: gconf
>  
> -gzip ugzip: libgzip.so
> +gzip ugzip: gzip
>  
> -http: libhttp.so
> +http: http
>  
> -pipe: libvfs-pipe.so
> +pipe: vfs-pipe
>  
> -#efs: libvefs.so
> +#efs: vefs
>  
> -#nfs: libnfs.so
> +#nfs: nfs
>  
> -ssh: libssh.so
> +ssh: ssh
>  
>  # The various access methods implemented by the extfs system.
> -a ar arj cpio deb hp48 lha mailfs patchfs rar rpm rpms trpm zip zoo: libextfs.so
> +a ar arj cpio deb hp48 lha mailfs patchfs rar rpm rpms trpm zip zoo: extfs
> Index: modules/ssl-modules.conf
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/ssl-modules.conf,v
> retrieving revision 1.2
> diff -u -r1.2 ssl-modules.conf
> --- modules/ssl-modules.conf	2001/06/10 20:08:11	1.2
> +++ modules/ssl-modules.conf	2001/09/04 21:59:48
> @@ -1 +1 @@
> -https: libhttp.so
> +https: http