Re: Themes Themes... Drool time?

[raster redhat com]

On 26 Feb, Joel Dillon shouted:
->  > ALL drawing code is outside of gtk (currently i have only moved butotn
->  > drawing code out). the theme contains all the code to do this - so gtk
->  > doesn't have any drawing code anymore. thsi makes gtkbuton about
->  > 400 lines shorter- and makes it cleaner. the theme library contains the
->  > drawing code - if no theme is specified the default theme library is
->  > loaded to do the drawing - which loosk just like what you have now.
->  
->    It seems better to have a 'default' drawing code built into gtk
->  in case loading the .so fails for some reason (library corruption,
->  dodgy paths or whatever). Putting everything in .so's adds something
->  else to go wrong ;)

well if loading of the default.so for gtk goes wrong libgtk.so probably
wont load either. :) the fact that some gtk code explicitly loads
another .so instead of relying on ld.so doesn't make it any worse. it
just gives finer grained control. if there isn't a default drawing code
library then there is a mangled installation and the likelyhood is that
other bits arent installed. You have to draw a line in the sand
somewhere - everyone wants it drawn somehwere else. Peoplle wen ton and
on about efficiency - so the most efficient is to only load the drawing
code you need - don't have 2 copes, the "default" and the theme's copy
just incase the theme doesn't load. The theme .so loaded shoudl fall
back if symbols arent' found or libraries aren't foudn to loading the
default  .so - if this is not loadable it is just as bad as havign a
corrupt filing system - so you have other things to worry about.

I may sound a bit dictatorial here - but I dont' see keeping the
drawing in gtk as anything of benefit - it just makes gtk bigger.

->  	Jo

-- 
--------------- Codito, ergo sum - "I code, therefore I am" --------------------
raster@rasterman.com       /\___ /\ ___/||\___ ____/|/\___  raster@redhat.com
Carsten Haitzler           | _ //__\\ __||_ __\\ ___|| _ /  Red Hat Advanced
218/21 Conner Drive        || // __ \\_ \ | |   \ _/_|| /   Development Labs
Chapel Hill NC 27514 USA   ||\\\/  \//__/ |_|   /___/||\\   919 547 0012 ext 282
+1 (919) 929 9443, 801 4392   For pure Enlightenmenthttp://www.rasterman.com/