Re: eggcups (and libgnomecups) for 2.12

On Wed, 2005-20-07 at 11:23 -0400, Colin Walters wrote:
> On Wed, 2005-07-20 at 09:05 -0600, Andreas J. Guelzow wrote:
> > Well, as far as I am concerned the polling of the cups printers is a big
> > pain. For example see bug 309277 . Rather than adding eggcups we should
> > really _remove_ that polling from gnome-print.
> As far as I can see from that bug the reporter is complaining about two
> things:
> 1) Lots of entries in the CUPS access log: well, the default CUPS access
>    log is verbose, simply tune it down.
> 2) The polling continuing after the print dialog has been closed: that's
>    definitely a bug.  I can't seem to reproduce it here.
> In any case these are bugs, not reasons to revert important end user
> visible functionality.

I disagree. The import of some of the eggcups into libgnomecups is now
apparently expecting that the cups client talks directly with the cups
daemon that is in charge of the printer(s). As a consequence, a
configuration with local cupsd daemons that pick up available printers
via broadcast (and is therefore immune to long timeout delays) is only
supported through a code change and recompilation of libgnomecups,

diff -u -r1.31 gnome-cups-printer.c
--- libgnomecups/gnome-cups-printer.c   28 Mar 2005 15:48:35 -0000
+++ libgnomecups/gnome-cups-printer.c   20 Jul 2005 15:33:23 -0000
@@ -282,7 +282,7 @@
  * that will produce an infinite loop when presented with an invalid
  * hostname.  This will also produce a hang if the remote printer is
  * unavailable and we do a syncronous lookup. */
-static gboolean go_directly_to_printer_when_possible = FALSE;
+static gboolean go_directly_to_printer_when_possible = TRUE;

(Note that the comment in the above code talks about the "hang" which
only happens without local cupsd daemons.)

So the "important end user visible functionality" in act makes this
library useless to many users. While this may be the result of bugs,
this situation in my mind discourages inclusion of this "feature".


Andreas J. Guelzow
Taliesin Software, Shelties, Pyr Sheps
and Shetland Sheep

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]