Re: [gpm] New stuff in CVS: graph legends
- From: Richard Hughes <hughsient gmail com>
- To: Julien Valroff <julien kirya net>
- Cc: gnome-power-manager-list gnome org
- Subject: Re: [gpm] New stuff in CVS: graph legends
- Date: Tue, 04 Apr 2006 20:33:01 +0100
On Tue, 2006-04-04 at 20:21 +0200, Julien Valroff wrote:
> [sorry for breaking the thread, had to copy n'paste from the ML
> archives, having accidentaly deleted the original email]
I'm not bothered.. :-)
> > I'm after comments/feedback on something new in CVS: graph legends.
> I would like to test all the new functions, but I can't build from CVS (HEAD) on Debian Testing:
> gpm-main.c: In function 'main':
> gpm-main.c:144: error: 'GNOME_PARAM_GOPTION_CONTEXT' undeclared (first use in this function)
> gpm-main.c:144: error: (Each undeclared identifier is reported only once
> gpm-main.c:144: error: for each function it appears in.)
> make: *** [gpm-main.o] Error 1
> I guess some packages are not up-to-date... I would tend to think
> libgnome-dev but it has the same version on testing and unstable
> (1.4.2-32 - with 32 being the Debian package revision)
devhelp has this: <libgnome/libgnome.h> -- Since 2.14
> And on Debian unstable:
> cc1: warnings being treated as errors
> gpm-graph-widget.c: In function 'gpm_graph_expose':
> gpm-graph-widget.c:681: warning: 'legend_height' may be used uninitialized in this function
> gpm-graph-widget.c:682: warning: 'legend_width' may be used uninitialized in this function
> make: *** [gpm-graph-widget.o] Error 1
Odd, my GCC doesn't catch this.
I've just committed:
2006-04-04 Richard Hughes <richard hughsie com>
* src/gpm-graph-widget.c (gpm_graph_draw_graph): Fix "legend_height
may be used uninitialized in this function" -- this is incorrect and
probably a GCC bug, but initialising them won't hurt.
> What's wrong now?
Me -- should work okay now. :-)
> > Ohh, and GNOME Power Manager is a little over a year old:
> Thanks for all your work. I really appreciate the way you care of all
> our end-users' problems. As I am far from being a developer, I can only
> offer testing and French translations when spare time permits it, but
> would like to do more to help you and GPM.
] [Thread Prev