Why the "Help" is disabled?



Hi, there,

I found a strange behavior of gnome-pilot-applet. When you startup the
applet, the "Help" button is enabled. But after "Forward" to next
screen, it's disabled. Forward one by one, you can find that sometimes
the "Help" button is enabled, sometimes it's disabled.

Why this happens? If there's any special purpose that we intended to do so?

I found some gnome_druid_set_buttons_sensitive function calls in source
code capplet/gnome-pilot-druid.c:
./capplet/gnome-pilot-druid.c:480: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (arg1), TRUE, ready, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:542: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, FALSE, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:600: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, ready, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:615: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, ready, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:631: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, ready, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:645: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, TRUE, TRUE, FALSE);
./capplet/gnome-pilot-druid.c:678: gnome_druid_set_buttons_sensitive
(GNOME_DRUID (priv->druid), TRUE, TRUE, TRUE, FALSE);

Seems the last parameter is always "FALSE", which means the "Help"
button should always be disable. As I saw, that's NOT the truth.
But after I changed line 480, in function gpd_cradle_page_prepare, from
FALSE to TRUE, then the "Help" button is enabled.

Is it a correct fix? How can I submit the patch?

Thanks.
Calvin



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]