RE: address-conduit: emailable pagers?

[Vadim Strizhevsky <vadim optonline net>]

Duh indeed. 
/me puts down his crackpipe for long enough to commit this patch. ;)

Thanks,
Vadim

Alan Shutko writes:
 > Admittedly, a bunch of people are getting email on their cell phones
 > and pagers these days.  (I work for a paging software company, I
 > should know.)  However, not all cell phones and pager numbers are
 > valid email addresses....
 > 
 > In the "Duh" department, I've discovered a bug in address-conduit such
 > that any cell phone and pager number appears as email, due to bit-wise
 > anding -1.  I believe this patch fixes it, and shouldn't break
 > anything, since email doesn't even use this table.
 > 
 > Index: address-conduit.c
 > ===================================================================
 > RCS file: /cvs/gnome/gnome-pim/gnomecard/address-conduit.c,v
 > retrieving revision 1.15
 > diff -c -c -r1.15 address-conduit.c
 > *** address-conduit.c	2000/02/17 06:32:38	1.15
 > --- address-conduit.c	2000/02/27 00:03:57
 > ***************
 > *** 99,105 ****
 >   	PHONE_HOME,
 >   	PHONE_FAX,
 >   	PHONE_PREF,   /* TODO: What to do with "Other"? */
 > ! 	-1,           /* email */
 >   	PHONE_PREF,
 >   	PHONE_PAGER,
 >   	PHONE_CELL
 > --- 99,105 ----
 >   	PHONE_HOME,
 >   	PHONE_FAX,
 >   	PHONE_PREF,   /* TODO: What to do with "Other"? */
 > ! 	0,           /* email */
 >   	PHONE_PREF,
 >   	PHONE_PAGER,
 >   	PHONE_CELL
 > 
 > 
 > -- 
 > Alan Shutko <ats@acm.org> - In a variety of flavors!
 > 258 days, 15 hours, 34 minutes, 24 till we run away.
 > I'd rather just believe that it's done by little elves running around.
 > 
 > 
 > -- 
 >         FAQ: Frequently-Asked Questions at http://www.gnome.org/gnomefaq
 >          To unsubscribe: mail gnome-pilot-list-request@gnome.org with 
 >                        "unsubscribe" as the Subject.
 > 
 >