[PATCH] email capplet capabilities extended

[Vadim Strizhevsky <vadim optonline net>]

Patrick Decowski writes:
 > vadim, i changed the logic in the ok/try/cancel thing, could you
 > please double check that this is the intended behavior? thanks.

I think tere are a couple of problems in your patch. 

First I get coredump if I try to "Revert". This is probably because of 
"gtk_entry_get_text". I had the same problem in the first try of
memo_file. According to the doc, the string returned by this function
is owned by GtkEntry, thus it shouldn't be freed or even stored. You
can't store it in the config directly, as it will be freed later. You
must be strduped first. I see backup conduit does the same thing, and
the reason it gets away with it because it never destroys the
config. [this will need to be fixed as well].

Second You need to handle the cancel case and I don't think
ok/try/cancel logic is actually fully correct. I'm going to write a
separate mail about this shortly to open for discussion. 

And third, and this Eskil's suggestion, is to use GtkOptionMenu instead
of GtkCombo for items that you don't want to allow people to type in
the choice. I.e. fixed choice of elements. I changed this in memo_file 
and it is used in PilotLink capplet. And it looks better, although by
default it looks too "short". Probably need to add some margin or
something [ I'll need to look at that].

-Vadim