Re: [PATCH] Expense conduit

[Owen Taylor <otaylor redhat com>]

Eskil Heyn Olsen <deity@dbc.dk> writes:

> > 	- do we just use g_error and g_warning if errors occur inside
> > 	the conduit while syncing? shouldn't there be a more uniform 
> > 	dialog box, so that it is absolutely clear that the error has 
> > 	to do with gnome-pilot?
> 
> The error dialog (I presume you mean the sigsegv error box) is a
> GnomeThing, not gpilotd. You should not use g_error unlesss extremely
> absolutely muymuy important. Muymuy important is eg. mallocing 10 bytes
> and failing.
 
g_error() (since it calls abort() and thus dumps core) should not be 
be used for any error case that doesn't reflect a bug in your
program. For any predictable error case, you should put up a nice
GnomeMessageBox. For errors which don't reflect a user handleable
situation, but for which you don't want to dump core.
g_warning(); exit(1) may be appropriate.

                                        Owen