Re: [gnome-network] Patch that removes libgnome/ui dependency

[Rodrigo Moya <rodrigo gnome-db org>]

On Thu, 2005-03-17 at 10:41 +0100, Rodrigo Moya wrote:
> On Fri, 2005-03-04 at 13:57 +0100, Kristof Vansant wrote:
> > http://bugzilla.gnome.org/show_bug.cgi?id=167218
> > 
> > Can someone plz review it.
> 
> looks goods to me, except for this:
> 
> 
> > -#ifdef ENABLE_NLS
> > -	bindtextdomain (GETTEXT_PACKAGE, GNOME_NETTOOL_LOCALEDIR);
> > -	bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
> > -	textdomain (GETTEXT_PACKAGE);
> > -#endif
> > +	/* Initialize i18n support */
> > +    gtk_set_locale ();
> > 
> do we really need to remove the bind* calls?

and this, when running the application:

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_locate_file:
assertion `program != NULL' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_locate_file:
assertion `program != NULL' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GConf-CRITICAL **: gconf_escape_key: assertion
`arbitrary_text != NULL' failed

(gnome-nettool:2529): GConf-CRITICAL **: gconf_client_add_dir: assertion
`gconf_valid_key (dirname, NULL)' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GLib-CRITICAL **: g_string_prepend: assertion
`val != NULL' failed

(gnome-nettool:2529): Gtk-CRITICAL **: gtk_accel_map_add_entry:
assertion `_gtk_accel_path_is_valid (accel_path)' failed

(gnome-nettool:2529): Gtk-CRITICAL **: gtk_widget_set_accel_path:
assertion `_gtk_accel_path_is_valid (accel_path)' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GLib-CRITICAL **: g_string_prepend: assertion
`val != NULL' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GLib-CRITICAL **: g_string_prepend: assertion
`val != NULL' failed

(gnome-nettool:2529): Gtk-CRITICAL **: gtk_accel_map_add_entry:
assertion `_gtk_accel_path_is_valid (accel_path)' failed

(gnome-nettool:2529): Gtk-CRITICAL **: gtk_widget_set_accel_path:
assertion `_gtk_accel_path_is_valid (accel_path)' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GLib-CRITICAL **: g_string_prepend: assertion
`val != NULL' failed

(gnome-nettool:2529): Gnome-CRITICAL **: gnome_program_get_app_id:
assertion `program != NULL' failed

(gnome-nettool:2529): GLib-CRITICAL **: g_string_prepend: assertion
`val != NULL' failed

(gnome-nettool:2529): Gtk-CRITICAL **: gtk_widget_set_accel_path:
assertion `_gtk_accel_path_is_valid (accel_path)' failed

-- 
Rodrigo Moya <rodrigo gnome-db org>