Re: [gnome-network] [PATCH] Gnome Nettool

[German Poo Caaman~o <gpoo ubiobio cl>]

El mar, 18-05-2004 a las 17:41, Carlos Garcia Campos escribió:
> Hi all, 
> 
> In the last days I have been working a bit in gnome-nettool. I have
> attached a tar.bz2 that contains:
> 
> * a src directory with the new files gn-combo-history.[ch]
> * a pixmaps directory with the new pixmaps
> * the patch nettool.diff
> 
> There are a lot changes, so I will paste the ChangeLog entry here, that
> I think it's enough explanatory itself:
> 
> * src/gnome-nettool.glade: s/GtkCombo/GtkComboBox and added a treeview
> to show the IP information when there are IPv6 ips.
> 
> * src/info.c (set_nic, load_iface, ip6_masklen,
> ip6_construct_address, get_nic_information, get_interfaces),
> src/info.h, src/main.c (list_ip_addr_add_columns,
> load_info_widgets_from_xml), src/nettol.h: IPv6 support.
> When there are IPv6 addresses, a treeview is shown with
> the information about all of the ip addresses, but if there aren't IPv6
> addresses, the IPv4 information is shown in text labels.

It seems there are operations over a tree_model where it's not valid
yet.

Just after run gnome-tool I get a bunch of warnings:

(gnome-nettool:6578): Gtk-CRITICAL **: file gtktreemodel.c: line 998
(gtk_tree_model_get_iter_first): assertion `GTK_IS_TREE_MODEL
(tree_model)' failed

> * src/callbacks.c (on_about_activate), src/main.c (main): uses
> PIXMAPS_DIR instead of GNOME_ICONDIR and gnome-nettool.png instead of
> gnome-netinfo.png
> 
> * src/gn-combo-history.[ch]: files added. It is an object to manage
> the history of new combo boxes
> 
> * src/main.c (load_*_widgets_from_xml), src/callbacks
> (on_*_activate): added support for history in
> new combo boxes

The history stored could be shared between all tabs, because is
high probable that the same instructions will be applied to 
the same hosts.

> * src/callbacks.c, src/info.c, src/ping.c, src/traceroute.c,
> src/lookup.c, src/util-mii.c: added #include <glib/gprintf.h> to avoid
> compile warnings about g_sprintf ()

Ok.  If now nettool depends on gtk 2.4, the g_sprintf function in 
util.c is not needed anymore.

May you fix the TreeView warnings?

Thanks,

-- 
Germán Poó Caamaño
mailto:gpoo ubiobio cl
http://www.ubiobio.cl/~gpoo/