Re: [gnome-network][PATCH] Update configure.in to summarize what will be built

[Germán Poó Caamaño <gpoo ubiobio cl>]

El lun, 05-01-2004 a las 23:45, Mason Kidd escribió:
> On Mon, 2004-01-05 at 08:50, Germán Poó Caamaño wrote:
> > El lun, 05-01-2004 a las 12:50, Mason Kidd escribió:
> > > On Mon, 2004-01-05 at 06:12, Germán Poó Caamaño wrote:
> > > > El dom, 04-01-2004 a las 22:47, Mason Kidd escribió:
> > > > > Hi everybody,
> > > > > The attached patch updates configure.in to summarize at the end of the
> > > > > configure script output, what components of gnome-network will be
> > > > > built.  It also separates out a little better the checks for required
> > > > > libs for each component, and allows disabling the building of individual
> > > > > components (i.e. --disable-pws to not build the Personal Web Server).
> > > > 
> > > > May you update your patch with the current CVS?
> > > > 
> > > > Thanks,
> > > No problem.  Updated patch is attached.
> > 
> > It looks ok, but it just missing a Changelog entry.  Could you add one?
> > 
> > Thanks,
> Heh, I'll get this right eventually. :)
> 
> Attached is a new patch.

Applied, Thanks.  I just have only one comment.  At the end of
configure.in looks like:

+
+AC_MSG_NOTICE([The following modules will be built:])
+if test "x$enable_desktopsharing" != "xno"; then
+       AC_MSG_NOTICE([     Desktop Sharing])
+fi
+if test "x$enable_pws" != "xno"; then
+       AC_MSG_NOTICE([     Personal Web Server])
+fi
+if test "x$enable_netinfo" != "xno"; then
+       AC_MSG_NOTICE([     Network Information])
+fi
+if test "x$enable_networkutil" != "xno"; then
+       AC_MSG_NOTICE([     Network Utilities])
+fi
+if test "x$enable_rdclient" != "xno"; then
+       AC_MSG_NOTICE([     Remote Desktop Client])
+fi

Instead to show them conditionles, I think it should be better is 
to show every module with yes or no to indicate if it will build
or not.

-- 
Germán Poó Caamaño
mailto:gpoo ubiobio cl
http://www.ubiobio.cl/~gpoo/