El mar, 18-11-2003 a las 17:56, William Jon McCann escribió:
> Carlos Garcia Campos wrote:
> > It doesn't work for IPv6. I don't know the reason but using a "size"
> > variable instead of sizeof in the connect system call, it works
> > perfectly for IPv4 and IPv6 (in my system). I have attached the patch
>
> Yes it is better. I have committed my patch with your suggestion. Thanks.
>
> However, I have a question about your patch.
>
> >>Index: scan.c
> >>===================================================================
> >>RCS file: /cvs/gnome/gnome-network/gnome-netinfo/scan.c,v
> >>retrieving revision 1.6
> >>diff -u -u -r1.6 scan.c
> >>--- scan.c 2 Oct 2003 21:26:16 -0000 1.6
> >>+++ scan.c 18 Nov 2003 13:33:25 -0000
> >>@@ -64,9 +64,16 @@
> >> gchar buf[SIZE];
> >> gchar *service_name = NULL;
> >> gint ip_version, pf;
> >>+ struct sockaddr *addr_ptr;
> >>+ gint size;
> >>
> >> g_return_if_fail (netinfo != NULL);
> >>
> >>+ if (netinfo_validate_host (netinfo) == FALSE) {
> >>+ netinfo_stop_process_command (netinfo);
> >>+ return;
> >>+ }
>
> What is the above for? It looks like something that we could use. I
> think providing some feedback to the user when they have entered an
> invalid hostname is a really good thing. Is that what this is for? Do
> you have a complete patch for this functionality?
Yes, sorry, this is a patch that I have already sent but it has not been
applied to cvs. I'm sure that Rodrigo or German will apply it when they
have time to see it.
http://lists.gnome.org/archives/gnome-network-list/2003-October/msg00081.html
> Jon
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Carlos Garcia Campos a.k.a. KaL
elkalmail yahoo es
carlosgc gnome org
Grupo Linups
Usuarios de SL/Linux de la UPSAM
http://www.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
PGP key: http://pgp.rediris.es:11371/pks/lookup?op=get&search=0x523E6462
Attachment:
signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente