Re: [gnome-network][PATCH] netinfo



El lun, 15-12-2003 a las 23:53, Carlos Garcia Campos escribió:
> El lun, 15-12-2003 a las 19:55, William Jon McCann escribió:
> > Hi,
> > 
> > This is a nice feature.  However, I think there is a slight problem with 
> > the way you have implemented it.
> > 
> > It assumes that only one process is going at a time.  For example, try this:
> > 
> > Start an unlimited number of pings.  Watch cursor is visible.  Go to 
> > Netstat and display routing information.  When it completes the watch 
> > cursor is gone.  However, the pings are still going.
> > 
> > Maybe the cursor state should be set individually for each notebook 
> > pages on the interface?
> 
> Yes, the cursor is set now only for each treeview. An updated patch have
> been attached.

I have done a minor improvement to the patch. The updated patch has been
attached.

Ok to commit??

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Carlos Garcia Campos a.k.a. KaL
   elkalmail yahoo es
   carlosgc gnome org
 Grupo Linups
   Usuarios de SL/Linux de la UPSAM
 http://www.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=		  
PGP key: http://pgp.rediris.es:11371/pks/lookup?op=get&search=0x523E6462
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Carlos Garcia Campos a.k.a. KaL
   elkalmail yahoo es
   carlosgc gnome org
 Grupo Linups
   Usuarios de SL/Linux de la UPSAM
 http://www.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=		  
PGP key: http://pgp.rediris.es:11371/pks/lookup?op=get&search=0x523E6462
Index: netinfo.c
===================================================================
RCS file: /cvs/gnome/gnome-network/gnome-netinfo/netinfo.c,v
retrieving revision 1.18
diff -u -u -r1.18 netinfo.c
--- netinfo.c	17 Dec 2003 18:06:37 -0000	1.18
+++ netinfo.c	25 Dec 2003 16:37:46 -0000
@@ -334,6 +356,8 @@
 netinfo_toggle_state (Netinfo * netinfo, gboolean state,
 		      gpointer user_data)
 {
+	GdkCursor *cursor;
+	
 	g_assert (netinfo != NULL);
 	g_return_if_fail (netinfo != NULL);
 
@@ -343,8 +367,16 @@
 	}
 
 	if (state) {
+		gdk_window_set_cursor ((netinfo->output)->window, NULL);
 		netinfo->child_pid = 0;
+	} else {
+		cursor = gdk_cursor_new (GDK_WATCH);
+		if (!GTK_WIDGET_REALIZED (netinfo->output))
+			gtk_widget_realize (GTK_WIDGET (netinfo->output));
+		gdk_window_set_cursor ((netinfo->output)->window, cursor);
+		gdk_cursor_destroy (cursor);
 	}
+	
 	netinfo->running = !state;
 
 	netinfo_toggle_button (netinfo);

Attachment: signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]