Re: E bug (patch included)

["Geoff Harrison (mandrake)" <mandrake mandrake net>]

On Sun, Jan 03, 1999 at 04:30:00PM +0100, Mattias Evensson wrote:
> I've found a bug thats makes E segfault when a session is saved. I've
> included a patch that fixes it (at least for me).
> 
> 	/Mattias
> ? diff
> Index: src/session.c
> ===================================================================
> RCS file: /cvs/gnome/e/src/session.c,v
> retrieving revision 1.10
> diff -c -r1.10 session.c
> *** session.c	1998/12/23 05:40:50	1.10
> --- session.c	1999/01/03 15:21:58
> ***************
> *** 87,108 ****
>      SmProp             *props[4];
>   
>      programProp.name = (char *)SmProgram;
> !    programProp.name = (char *)SmLISTofARRAY8;
>      programProp.num_vals = 1;
>      programProp.vals = &programVal;
>   
>      userIDProp.name = (char *)SmUserID;
> !    userIDProp.name = (char *)SmLISTofARRAY8;
>      userIDProp.num_vals = 1;
>      userIDProp.vals = &userIDVal;
>   
>      restartProp.name = (char *)SmRestartCommand;
> !    restartProp.name = (char *)SmLISTofARRAY8;
>      restartProp.num_vals = 3;
>      restartProp.vals = (SmPropValue *) & restartVal;
>   
>      cloneProp.name = (char *)SmCloneCommand;
> !    cloneProp.name = (char *)SmLISTofARRAY8;
>      cloneProp.num_vals = 3;
>      cloneProp.vals = (SmPropValue *) & restartVal;
>   
> --- 87,108 ----
>      SmProp             *props[4];
>   
>      programProp.name = (char *)SmProgram;
> !    programProp.type = (char *)SmLISTofARRAY8;
>      programProp.num_vals = 1;
>      programProp.vals = &programVal;
>   
>      userIDProp.name = (char *)SmUserID;
> !    userIDProp.type = (char *)SmLISTofARRAY8;
>      userIDProp.num_vals = 1;
>      userIDProp.vals = &userIDVal;
>   
>      restartProp.name = (char *)SmRestartCommand;
> !    restartProp.type = (char *)SmLISTofARRAY8;
>      restartProp.num_vals = 3;
>      restartProp.vals = (SmPropValue *) & restartVal;
>   
>      cloneProp.name = (char *)SmCloneCommand;
> !    cloneProp.type = (char *)SmLISTofARRAY8;
>      cloneProp.num_vals = 3;
>      cloneProp.vals = (SmPropValue *) & restartVal;
>   

okay - now call me crazy but I don't see the patched bits in here at all - in
fact I don't see a difference at all either between the two segments or between
what is in this file and what's in cvs right now.  you sure you sent the right
patch?

-- 
Geoff Harrison (http://mandrake.net)
President - Enlightened Solutions, Inc.
Author, MAW Shell Replacement (http://mandrake.net/MAW)
Author, Enlightenment Window Manager (http://www.enlightenment.org)
phone: (404)760-8164