Re: Can we integrate this patch into popt, please?



>>>>> "Brandon" == Brandon S Allbery <allbery@ece.cmu.edu> writes:

Brandon> Having an admittedly ugly $CC setting which is necessary to
Brandon> sneak options past some decidedly antisocial (non-GNU)
Brandon> configure scripts, this patch to popt/configure.in is
Brandon> necessary for ORBit to build here.  It's also more correct,
Brandon> since someone may use a full pathname to gcc.

Brandon> -if test $CC = gcc; then
Brandon> +if test $ac_cv_prog_gcc = yes; then

Actually, neither of these is the right way to test to see if the
compiler is gcc.

The first fails if gcc happens to have a different name.  This happens
more frequently than you might thing (apparently many people install
both gcc and egcs on their machines, and name egcs "egcs").

The second is bad because cache variable names occasionally change
with new autoconf versions.

Luckily, in this case there is a documented way to do the test:

	test "$GCC" = yes

Read the docs for AC_PROG_CC.

Tom



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]