Re: [PATCH] libgtop 0.26.2: --disable-static doesn't work

[Raja R Harinath <harinath cs umn edu>]

Martin Baulig <martin@home-of-linux.org> writes:
> On Mon, 28 Sep 1998, Alexander Jolk wrote:
> > The libgtop 0.26.2 from CVS won't compile if ones gives the
> > `--disable-static' option to configure because it tries to build
> > several statically linked examples programs.  I patched the
> > configure.in script and the relevant Makefile.am so that the
> > statically linked examples are only built if static libraries are
> > enabled.
[snip]
> > Index: examples/Makefile.am
> > ===================================================================
> > RCS file: /cvs/gnome/libgtop/examples/Makefile.am,v
> > retrieving revision 1.15
> > diff -u -r1.15 Makefile.am
> > --- Makefile.am	1998/09/09 16:22:12	1.15
> > +++ Makefile.am	1998/09/28 15:48:10
> > @@ -9,12 +9,14 @@
> >  # We install it in `libexec' since this will make it more easy
> >  # to put the examples into an extra RPM package.
> >  
> > -libexec_PROGRAMS	= first first_static second second_static \
> > -			  mountlist mountlist_static \
> > -			  procmap procmap_static \
> > +libexec_PROGRAMS	= first second\
> > +			  mountlist procmap \
> > +			  @static_targets@ \
> >  			  @guile_examples@ @smp_examples@
>   
> Looks reasonable to me, just applied it to CVS. Thanks !

BTW, why are these programs installed in $libexecdir?  At least try to
put the into

	$libexec/libgtop

or something like that.  `first' and `second' contain no meaningful
reference to the `libgtop' package.  Not everyone will run `ldd' to see
that this uses libgtop.

I don't think concerns about "easing" packaging should drive stuff,
either.  I may not want example programs to be installed.  I would
prefer this to be hidden inside an "--enable-install-examples" or
something like that.

- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash