swallow bug found

The problem with swallowing non-gtk windows is caused by the
gdk_window_reparent function.  In this function old_parent_private is
NULL, because the foreign window has no gdk parent.

The following patch resolves the problem, swallowing of xconsole works 

Index: gdkwindow.c
RCS file: /cvs/gnome/gtk+/gdk/gdkwindow.c,v
retrieving revision 1.50
diff -u -r1.50 gdkwindow.c
--- gdkwindow.c 1998/07/04 15:30:01     1.50
+++ gdkwindow.c 1998/07/13 14:58:47
@@ -853,7 +853,8 @@
                     x, y);
-  old_parent_private->children = g_list_remove (old_parent_private->children, window);
+  if (old_parent_private)
+    old_parent_private->children = g_list_remove (old_parent_private->children, window);
   parent_private->children = g_list_prepend (parent_private->children, window);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]